-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Masterbar: allow logging out of wpcom when logging out of site. #12457
Conversation
Fixes #12456 This change avoids initialiazing all of the Masterbar after admin_bar_init. We want the module to be available after logging out as well, so the function hooked into wp_logout can be triggered.
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: June 4, 2019. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works well for the first log-out attempt: I got logged out from both WP site and WPCOM. When I tried to log out for the second time, it won't log me out from WPCOM. I tried logging out from both admin pages and a non-amp frontend view
@brbrr Could you clarify the steps you followed:
Were you using SSO on the site? |
Yeah, I should mention that I’ve been using SSO for most of my testing. The steps are correct, although 2,3 are combined to single step since I used SSO to login |
I retested it with SSO enabled and disabled and I can replicate the issue I mentioned above. So logging out via WPCOM masterbar did not logs you out from WPCOM on subsequent attempts |
I can't seem to reproduce unfortunately. It always appears to log me out of both instances. :( @kraftbj Do you think you could give it a try as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, good catch @brbrr. I was able the failure on the second attempt both with SSO on and off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue previously reported (unable to log out on a second attempt) still exists; however, confirmed it was present before the bug this PR is trying to fixed was introduced.
I'm approving as this fixes the behavior back to JP 6.9, but we need a new one to fix the second logout issue.
This seems to be a separate issue from this PR. It existed in previous versions of Jetpack. I logged it in #12465
* Kick off the changelog * Add 7.3.1 * Update date and post link * changelog: add #12219 * changelog: add #12170 * changelog: add #12184 * Changelog: add #12268 * Changelog: add #12081 * Changelog: add #12323 * Changelog: add #12204 * Changelog: add #12269 * Changelog: add #12332 * changelog: add #12339 * changelog: add #12209 * Changelog: add #12319 * Changelog: add #12357 * Changelog: add #12124 * Changelog: add #12373 * Changelog: add #12252 * Changelog: add #12383 * Changelog: add #12372 * changelog: add #12337 * Changelog: add #12290 * Changelog: add #12301 * Changelog: add #12061 * Testing list: add instructions for #12061 * Changelog: add #12393 * Update minimum supported version See #12287 * Changelog: add #12406 * Testing list: add #12406 * Changelog: add #12277 * Changelog: add #12412 * Changelog: add #11318 * Changelog: add #12328 * Changelog: add #12425 * Changelog: add #12380 * Changelog: add #12428 * Changelog: add #12414 * Changelog: add #12395 * Changelog & Testing list: add #12416, #12417, #12418, and #12348 * changelog: add #12379 * Changelog: add #12341 * changelog: add #12444 * Changelog: add #12434 * Changelog: add #12454 * Changelog: add #12460 * Changelog: add #12463 * Changelog: add #12457 * Changelog / testing list: add #10333 * Changelog: add #12467 Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Fixes #12456
Changes proposed in this Pull Request:
This change avoids initialiazing all of the Masterbar after
admin_bar_init
. We want the module to be available after logging out as well, so the function hooked intowp_logout
can be triggered.Testing instructions:
Proposed changelog entry for your changes: